Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dropdown): update usage.mdx #1061

Merged
merged 1 commit into from
Mar 30, 2020
Merged

chore(dropdown): update usage.mdx #1061

merged 1 commit into from
Mar 30, 2020

Conversation

joshblack
Copy link
Contributor

Update usage info for dropdown vs select. The core distinction is not that a user can customize the dropdown but that the dropdown itself is styled to match the design system whereas the select uses the browser default.

Changelog

New

Changed

  • Update dropdown usage guidance

Removed

@joshblack joshblack requested a review from a team March 30, 2020 20:22
@joshblack joshblack requested a review from a team as a code owner March 30, 2020 20:22
@joshblack joshblack requested review from janchild and removed request for a team March 30, 2020 20:22
@vercel
Copy link

vercel bot commented Mar 30, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/carbon-design-system/carbon-website/d2egdy6ty
✅ Preview: https://carbon-website-git-joshblack-patch-1.carbon-design-system.now.sh

@ghost ghost requested review from abbeyhrt and asudoh and removed request for a team March 30, 2020 20:22
@joshblack joshblack mentioned this pull request Mar 30, 2020
Merged
@janchild janchild merged commit ed4f4c4 into master Mar 30, 2020
@janchild janchild deleted the joshblack-patch-1 branch March 30, 2020 20:42
@netlify
Copy link

netlify bot commented Mar 31, 2020 •
edited
Loading

Deploy preview for carbon-website ready!

Built with commit 7be0144

https://deploy-preview-1061--carbon-website.netlify.com

natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@joshblack @natashadecoste
Update usage.mdx (carbon-design-system#1061)
b033269
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@joshblack @natashadecoste
Update usage.mdx (carbon-design-system#1061)
099b2f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janchild janchild janchild approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@abbeyhrt abbeyhrt Awaiting requested review from abbeyhrt

@asudoh asudoh Awaiting requested review from asudoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @alisonjoseph @janchild